Commit Graph

7 Commits

Author SHA1 Message Date
eggplants
a250e1d71e fix: metadata.name does not accept attr 2022-02-03 21:16:59 +09:00
eggplants
2685fefc88 add: E501 to flake ignore 2022-02-03 20:29:12 +09:00
eggplants
5e491aaf55 fix: flake8 section in setup.cfg 2022-02-03 20:28:02 +09:00
eggplants
f14bae0c3e add: configure files (setup.py->setup.py+setup.cfg+pyproject.toml) 2022-02-03 20:26:37 +09:00
AntiCompositeNumber
be7642c837 Code style improvements (#20)
* Add sane line length to setup.cfg

* Use Black for quick readability improvements

* Clean up exceptions, docstrings, and comments

Docstrings on dunder functions are redundant and typically ignored
Limit to reasonable line length
General grammar and style corrections
Clarify docstrings and exceptions
Format docstrings per PEP 257 -- Docstring Conventions

* Move archive_url_parser out of Url.save()

It's generally poor form to define a function in a function, as it will
be re-defined each time the function is run.

archive_url_parser does not depend on anything in Url, so it makes sense
to move it out of the class.

* move wayback_timestamp out of class, mark private functions

* DRY in _wayback_timestamp

* Url._url_check should return None

There's no point in returning True if it's never checked and won't ever
be False.
Implicitly returning None or raising an exception is more idiomatic.

* Default parameters should be type-consistant with expected values

* Specify parameters to near

* Use datetime.datetime in _wayback_timestamp

* cleanup __init__.py

* Cleanup formatting in tests

* Fix names in tests

* Revert "Use datetime.datetime in _wayback_timestamp"

This reverts commit 5b30380865.

Introduced unnecessary complexity

* Move _get_response outside of Url

Because Codacy reminded me that I missed it.

* fix imports in tests
2020-07-22 10:09:14 +05:30
akamhy
151df94fe3 license_file = LICENSE 2020-05-07 19:38:19 +05:30
akamhy
09a521ae43 Create setup.cfg 2020-05-04 16:23:00 +05:30