Commit Graph
9 Commits
Author SHA1 Message Date
AntiCompositeNumber 9dfb87fae3 Specify parameters to near 2020-07-21 17:04:17 -04:00
AntiCompositeNumber 23443ba2ec Default parameters should be type-consistant with expected values 2020-07-21 16:36:22 -04:00
AntiCompositeNumber 168ef1854a Url._url_check should return None
There's no point in returning True if it's never checked and won't ever
be False.
Implicitly returning None or raising an exception is more idiomatic.
2020-07-21 16:34:33 -04:00
AntiCompositeNumber 77bc275333 DRY in _wayback_timestamp 2020-07-21 16:30:53 -04:00
AntiCompositeNumber 10e918eebf move wayback_timestamp out of class, mark private functions 2020-07-21 16:23:29 -04:00
AntiCompositeNumber bec26c4bae Move archive_url_parser out of Url.save()
It's generally poor form to define a function in a function, as it will
be re-defined each time the function is run.

archive_url_parser does not depend on anything in Url, so it makes sense
to move it out of the class.
2020-07-21 15:52:27 -04:00
AntiCompositeNumber b3c68add55 Clean up exceptions, docstrings, and comments
Docstrings on dunder functions are redundant and typically ignored
Limit to reasonable line length
General grammar and style corrections
Clarify docstrings and exceptions
Format docstrings per PEP 257 -- Docstring Conventions
2020-07-21 15:46:16 -04:00
AntiCompositeNumber fd74e62ff9 Use Black for quick readability improvements 2020-07-21 14:25:49 -04:00
AntiCompositeNumber 3ac7c7ab86 Add sane line length to setup.cfg 2020-07-21 14:25:26 -04:00